chore(m5): delete connector-sdk + connectors packages#116
Merged
Conversation
The connector engine and renderer surface are gone; the only remaining references to these packages were workspace plumbing (lockfile, CI, pack-connector script). Delete them. - packages/connector-sdk/ — entire package (12 source files + README + package.json + tsconfig). The published @spool-lab/connector-sdk on npm is now sourced from spool-lab/spool-daemon. - packages/connectors/ — 6 built-in connectors (github, hackernews-hot, reddit, twitter-bookmarks, typeless, xiaohongshu) plus the .gitkeep - pnpm-workspace.yaml — drop the "packages/connectors/*" line; only app, cli, core, landing remain in the workspace - .github/workflows/e2e.yml — drop 3 connector-sdk build/test steps - scripts/pack-connector.sh — delete (no connectors left to pack) - pnpm-lock.yaml — synced (8 connector workspace entries removed) `pnpm install --frozen-lockfile` clean. Core / CLI / app builds and tests all green; CLI smoke (sync/status/search) against the Claude fixture works end-to-end. Net -3334 across 43 files. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continuation of #112 / #113 / #114 / #115. The connector engine, renderer surface, IPC, CLI, and DB schema are all gone now — the only remaining traces of the connector subsystem in this repo were the workspace plumbing for the connector packages themselves. This PR removes them.
-3334 / +0net across 43 files.Deleted
packages/connector-sdk/— entire package (12 source files + README + package.json + tsconfig). The published@spool-lab/connector-sdkon npm is now sourced from thespool-lab/spool-daemonrepo, which has been the single source of truth since that repo went public.packages/connectors/— 6 built-in connectors (github,hackernews-hot,reddit,twitter-bookmarks,typeless,xiaohongshu) plus.gitkeepscripts/pack-connector.sh— the helper that bundled connectors into publish-ready tarballs (no connectors to pack)Workspace plumbing
pnpm-workspace.yaml— dropped thepackages/connectors/*glob. Workspace is nowapp,cli,core,landing..github/workflows/e2e.yml— dropped 3pnpm --filter @spool-lab/connector-sdk build|teststeps from both theunitande2ejobspnpm-lock.yaml— synced (8 connector workspace entries removed)Features that should still work post-PR (verified)
pnpm install --frozen-lockfilepnpm --filter @spool-lab/core buildclean; 48/48 tests passpnpm --filter @spool-lab/cli buildclean; 21/21 tests passpnpm --filter @spool/app exec tsc --noEmitcleanspool sync / status / searchuser_version = 5with nocapture*tablesTest plan
pnpm install --frozen-lockfileclean (the gotcha that bit chore(m5): drop core connector engine + DB v5 migration #115)🤖 Generated with Claude Code